Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trustless-only mode (RAINBOW_TRUSTLESS_GATEWAY_DOMAINS) #81
feat: trustless-only mode (RAINBOW_TRUSTLESS_GATEWAY_DOMAINS) #81
Changes from all commits
3331d3b
1d2cf29
999f25c
82eadcb
eea1209
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 should be good enough to merge, but not a real end-to-end, because we can break the way config gets set via
RAINBOW_TRUSTLESS_GATEWAY_DOMAINS
or CLI parameter.Filled #89 to figure out better end-to-end test setup for config (not just this feature).
Check warning on line 358 in handlers.go
Codecov / codecov/patch
handlers.go#L356-L358
Check warning on line 49 in main.go
Codecov / codecov/patch
main.go#L49
Check warning on line 54 in main.go
Codecov / codecov/patch
main.go#L54
Check warning on line 98 in main.go
Codecov / codecov/patch
main.go#L98
Check warning on line 110 in main.go
Codecov / codecov/patch
main.go#L104-L110
Check warning on line 277 in main.go
Codecov / codecov/patch
main.go#L277
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ I've added this to make it easy to eyeball in logs/terminal if/when specific domains got set up correctly.
Check warning on line 349 in main.go
Codecov / codecov/patch
main.go#L342-L349
Check warning on line 351 in main.go
Codecov / codecov/patch
main.go#L351
Check warning on line 442 in main.go
Codecov / codecov/patch
main.go#L439-L442