deps: bump the react-deps group across 1 directory with 3 updates #518

dependabot · 2024-12-06T17:49:53Z

Bumps the react-deps group with 3 updates in the / directory: react, @types/react and react-dom.

Updates react from 18.3.1 to 19.0.0

Release notes

19.0.0 (December 5, 2024)

Below is a list of all new features, APIs, deprecations, and breaking changes. Read React 19 release post and React 19 upgrade guide for more information.

Note: To help make the upgrade to React 19 easier, we’ve published a react@18.3 release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. We recommend upgrading to React 18.3.1 first to help identify any issues before upgrading to React 19.

New Features

React

Actions: startTransition can now accept async functions. Functions passed to startTransition are called “Actions”. A given Transition can include one or more Actions which update state in the background and update the UI with one commit. In addition to updating state, Actions can now perform side effects including async requests, and the Action will wait for the work to finish before finishing the Transition. This feature allows Transitions to include side effects like fetch() in the pending state, and provides support for error handling, and optimistic updates.

useActionState: is a new hook to order Actions inside of a Transition with access to the state of the action, and the pending state. It accepts a reducer that can call Actions, and the initial state used for first render. It also accepts an optional string that is used if the action is passed to a form action prop to support progressive enhancement in forms.

useOptimistic: is a new hook to update state while a Transition is in progress. It returns the state, and a set function that can be called inside a transition to “optimistically” update the state to expected final value immediately while the Transition completes in the background. When the transition finishes, the state is updated to the new value.

use: is a new API that allows reading resources in render. In React 19, use accepts a promise or Context. If provided a promise, use will suspend until a value is resolved. use can only be used in render but can be called conditionally.

ref as a prop: Refs can now be used as props, removing the need for forwardRef.

Suspense sibling pre-warming: When a component suspends, React will immediately commit the fallback of the nearest Suspense boundary, without waiting for the entire sibling tree to render. After the fallback commits, React will schedule another render for the suspended siblings to “pre-warm” lazy requests.

React DOM Client

<form> action prop: Form Actions allow you to manage forms automatically and integrate with useFormStatus. When a <form> action succeeds, React will automatically reset the form for uncontrolled components. The form can be reset manually with the new requestFormReset API.

<button> and <input> formAction prop: Actions can be passed to the formAction prop to configure form submission behavior. This allows using different Actions depending on the input.

useFormStatus: is a new hook that provides the status of the parent <form> action, as if the form was a Context provider. The hook returns the values: pending, data, method, and action.

Support for Document Metadata: We’ve added support for rendering document metadata tags in components natively. React will automatically hoist them into the <head> section of the document.

Support for Stylesheets: React 19 will ensure stylesheets are inserted into the <head> on the client before revealing the content of a Suspense boundary that depends on that stylesheet.

Support for async scripts: Async scripts can be rendered anywhere in the component tree and React will handle ordering and deduplication.

Support for preloading resources: React 19 ships with preinit, preload, prefetchDNS, and preconnect APIs to optimize initial page loads by moving discovery of additional resources like fonts out of stylesheet loading. They can also be used to prefetch resources used by an anticipated navigation.

React DOM Server

Added prerender and prerenderToNodeStream APIs for static site generation. They are designed to work with streaming environments like Node.js Streams and Web Streams. Unlike renderToString, they wait for data to load for HTML generation.

React Server Components

RSC features such as directives, server components, and server functions are now stable. This means libraries that ship with Server Components can now target React 19 as a peer dependency with a react-server export condition for use in frameworks that support the Full-stack React Architecture. The underlying APIs used to implement a React Server Components bundler or framework do not follow semver and may break between minors in React 19.x. See docs for how to support React Server Components.

Deprecations

Deprecated: element.ref access: React 19 supports ref as a prop, so we’re deprecating element.ref in favor of element.props.ref. Accessing will result in a warning.

react-test-renderer: In React 19, react-test-renderer logs a deprecation warning and has switched to concurrent rendering for web usage. We recommend migrating your tests to @testinglibrary.com/docs/react-testing-library/intro/) or @testingesting-library.com/docs/react-native-testing-library/intro)

Breaking Changes

React 19 brings in a number of breaking changes, including the removals of long-deprecated APIs. We recommend first upgrading to 18.3.1, where we've added additional deprecation warnings. Check out the upgrade guide for more details and guidance on codemodding.

React

New JSX Transform is now required: We introduced a new JSX transform in 2020 to improve bundle size and use JSX without importing React. In React 19, we’re adding additional improvements like using ref as a prop and JSX speed improvements that require the new transform.

Errors in render are not re-thrown: Errors that are not caught by an Error Boundary are now reported to window.reportError. Errors that are caught by an Error Boundary are reported to console.error. We’ve introduced onUncaughtError and onCaughtError methods to createRoot and hydrateRoot to customize this error handling.

Removed: propTypes: Using propTypes will now be silently ignored. If required, we recommend migrating to TypeScript or another type-checking solution.

Removed: defaultProps for functions: ES6 default parameters can be used in place. Class components continue to support defaultProps since there is no ES6 alternative.

Removed: contextTypes and getChildContext: Legacy Context for class components has been removed in favor of the contextType API.

... (truncated)

Changelog

Sourced from react's changelog.

19.0.0 (December 5, 2024)

Below is a list of all new features, APIs, deprecations, and breaking changes. Read React 19 release post and React 19 upgrade guide for more information.

Note: To help make the upgrade to React 19 easier, we’ve published a react@18.3 release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. We recommend upgrading to React 18.3.1 first to help identify any issues before upgrading to React 19.

New Features

React

Actions: startTransition can now accept async functions. Functions passed to startTransition are called “Actions”. A given Transition can include one or more Actions which update state in the background and update the UI with one commit. In addition to updating state, Actions can now perform side effects including async requests, and the Action will wait for the work to finish before finishing the Transition. This feature allows Transitions to include side effects like fetch() in the pending state, and provides support for error handling, and optimistic updates.

useActionState: is a new hook to order Actions inside of a Transition with access to the state of the action, and the pending state. It accepts a reducer that can call Actions, and the initial state used for first render. It also accepts an optional string that is used if the action is passed to a form action prop to support progressive enhancement in forms.

useOptimistic: is a new hook to update state while a Transition is in progress. It returns the state, and a set function that can be called inside a transition to “optimistically” update the state to expected final value immediately while the Transition completes in the background. When the transition finishes, the state is updated to the new value.

use: is a new API that allows reading resources in render. In React 19, use accepts a promise or Context. If provided a promise, use will suspend until a value is resolved. use can only be used in render but can be called conditionally.

ref as a prop: Refs can now be used as props, removing the need for forwardRef.

Suspense sibling pre-warming: When a component suspends, React will immediately commit the fallback of the nearest Suspense boundary, without waiting for the entire sibling tree to render. After the fallback commits, React will schedule another render for the suspended siblings to “pre-warm” lazy requests.

React DOM Client

<form> action prop: Form Actions allow you to manage forms automatically and integrate with useFormStatus. When a <form> action succeeds, React will automatically reset the form for uncontrolled components. The form can be reset manually with the new requestFormReset API.

<button> and <input> formAction prop: Actions can be passed to the formAction prop to configure form submission behavior. This allows using different Actions depending on the input.

useFormStatus: is a new hook that provides the status of the parent <form> action, as if the form was a Context provider. The hook returns the values: pending, data, method, and action.

Support for Document Metadata: We’ve added support for rendering document metadata tags in components natively. React will automatically hoist them into the <head> section of the document.

Support for Stylesheets: React 19 will ensure stylesheets are inserted into the <head> on the client before revealing the content of a Suspense boundary that depends on that stylesheet.

Support for async scripts: Async scripts can be rendered anywhere in the component tree and React will handle ordering and deduplication.

Support for preloading resources: React 19 ships with preinit, preload, prefetchDNS, and preconnect APIs to optimize initial page loads by moving discovery of additional resources like fonts out of stylesheet loading. They can also be used to prefetch resources used by an anticipated navigation.

React DOM Server

Added prerender and prerenderToNodeStream APIs for static site generation. They are designed to work with streaming environments like Node.js Streams and Web Streams. Unlike renderToString, they wait for data to load for HTML generation.

React Server Components

RSC features such as directives, server components, and server functions are now stable. This means libraries that ship with Server Components can now target React 19 as a peer dependency with a react-server export condition for use in frameworks that support the Full-stack React Architecture. The underlying APIs used to implement a React Server Components bundler or framework do not follow semver and may break between minors in React 19.x. See docs for how to support React Server Components.

Deprecations

Deprecated: element.ref access: React 19 supports ref as a prop, so we’re deprecating element.ref in favor of element.props.ref. Accessing will result in a warning.

react-test-renderer: In React 19, react-test-renderer logs a deprecation warning and has switched to concurrent rendering for web usage. We recommend migrating your tests to @testing-library/react or @testing-library/react-native

Breaking Changes

React 19 brings in a number of breaking changes, including the removals of long-deprecated APIs. We recommend first upgrading to 18.3.1, where we've added additional deprecation warnings. Check out the upgrade guide for more details and guidance on codemodding.

React

New JSX Transform is now required: We introduced a new JSX transform in 2020 to improve bundle size and use JSX without importing React. In React 19, we’re adding additional improvements like using ref as a prop and JSX speed improvements that require the new transform.

Errors in render are not re-thrown: Errors that are not caught by an Error Boundary are now reported to window.reportError. Errors that are caught by an Error Boundary are reported to console.error. We’ve introduced onUncaughtError and onCaughtError methods to createRoot and hydrateRoot to customize this error handling.

Removed: propTypes: Using propTypes will now be silently ignored. If required, we recommend migrating to TypeScript or another type-checking solution.

Removed: defaultProps for functions: ES6 default parameters can be used in place. Class components continue to support defaultProps since there is no ES6 alternative.

... (truncated)

Commits

e137890 [string-refs] cleanup string ref code (#31443)
d1f0472 [string-refs] remove enableLogStringRefsProd flag (#31414)
3dc1e48 Followup: remove dead test code from #30346 (#31415)
07aa494 Remove enableRefAsProp feature flag (#30346)
45804af [flow] Eliminate usage of more than 1-arg React.AbstractComponent in React ...
5636fad [string-refs] log string ref from prod (#31161)
b78a7f2 [rcr] Re-export useMemoCache in top level React namespace (#31139)
4e9540e [Fiber] Log the Render/Commit phases and the gaps in between (#31016)
d4688df [Fiber] Track Event Time, startTransition Time and setState Time (#31008)
15da917 Don't read currentTransition back from internals (#30991)
Additional commits viewable in compare view

Updates @types/react from 18.3.14 to 19.0.1

Commits

See full diff in compare view

Updates react-dom from 18.3.1 to 19.0.0

Release notes

Sourced from react-dom's releases.

19.0.0 (December 5, 2024)

Below is a list of all new features, APIs, deprecations, and breaking changes. Read React 19 release post and React 19 upgrade guide for more information.

Note: To help make the upgrade to React 19 easier, we’ve published a react@18.3 release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. We recommend upgrading to React 18.3.1 first to help identify any issues before upgrading to React 19.

New Features

React

Actions: startTransition can now accept async functions. Functions passed to startTransition are called “Actions”. A given Transition can include one or more Actions which update state in the background and update the UI with one commit. In addition to updating state, Actions can now perform side effects including async requests, and the Action will wait for the work to finish before finishing the Transition. This feature allows Transitions to include side effects like fetch() in the pending state, and provides support for error handling, and optimistic updates.

useActionState: is a new hook to order Actions inside of a Transition with access to the state of the action, and the pending state. It accepts a reducer that can call Actions, and the initial state used for first render. It also accepts an optional string that is used if the action is passed to a form action prop to support progressive enhancement in forms.

useOptimistic: is a new hook to update state while a Transition is in progress. It returns the state, and a set function that can be called inside a transition to “optimistically” update the state to expected final value immediately while the Transition completes in the background. When the transition finishes, the state is updated to the new value.

use: is a new API that allows reading resources in render. In React 19, use accepts a promise or Context. If provided a promise, use will suspend until a value is resolved. use can only be used in render but can be called conditionally.

ref as a prop: Refs can now be used as props, removing the need for forwardRef.

Suspense sibling pre-warming: When a component suspends, React will immediately commit the fallback of the nearest Suspense boundary, without waiting for the entire sibling tree to render. After the fallback commits, React will schedule another render for the suspended siblings to “pre-warm” lazy requests.

React DOM Client

<form> action prop: Form Actions allow you to manage forms automatically and integrate with useFormStatus. When a <form> action succeeds, React will automatically reset the form for uncontrolled components. The form can be reset manually with the new requestFormReset API.

<button> and <input> formAction prop: Actions can be passed to the formAction prop to configure form submission behavior. This allows using different Actions depending on the input.

useFormStatus: is a new hook that provides the status of the parent <form> action, as if the form was a Context provider. The hook returns the values: pending, data, method, and action.

Support for Document Metadata: We’ve added support for rendering document metadata tags in components natively. React will automatically hoist them into the <head> section of the document.

Support for Stylesheets: React 19 will ensure stylesheets are inserted into the <head> on the client before revealing the content of a Suspense boundary that depends on that stylesheet.

Support for async scripts: Async scripts can be rendered anywhere in the component tree and React will handle ordering and deduplication.

Support for preloading resources: React 19 ships with preinit, preload, prefetchDNS, and preconnect APIs to optimize initial page loads by moving discovery of additional resources like fonts out of stylesheet loading. They can also be used to prefetch resources used by an anticipated navigation.

React DOM Server

Added prerender and prerenderToNodeStream APIs for static site generation. They are designed to work with streaming environments like Node.js Streams and Web Streams. Unlike renderToString, they wait for data to load for HTML generation.

React Server Components

RSC features such as directives, server components, and server functions are now stable. This means libraries that ship with Server Components can now target React 19 as a peer dependency with a react-server export condition for use in frameworks that support the Full-stack React Architecture. The underlying APIs used to implement a React Server Components bundler or framework do not follow semver and may break between minors in React 19.x. See docs for how to support React Server Components.

Deprecations

Deprecated: element.ref access: React 19 supports ref as a prop, so we’re deprecating element.ref in favor of element.props.ref. Accessing will result in a warning.

react-test-renderer: In React 19, react-test-renderer logs a deprecation warning and has switched to concurrent rendering for web usage. We recommend migrating your tests to @testinglibrary.com/docs/react-testing-library/intro/) or @testingesting-library.com/docs/react-native-testing-library/intro)

Breaking Changes

React 19 brings in a number of breaking changes, including the removals of long-deprecated APIs. We recommend first upgrading to 18.3.1, where we've added additional deprecation warnings. Check out the upgrade guide for more details and guidance on codemodding.

React

New JSX Transform is now required: We introduced a new JSX transform in 2020 to improve bundle size and use JSX without importing React. In React 19, we’re adding additional improvements like using ref as a prop and JSX speed improvements that require the new transform.

Errors in render are not re-thrown: Errors that are not caught by an Error Boundary are now reported to window.reportError. Errors that are caught by an Error Boundary are reported to console.error. We’ve introduced onUncaughtError and onCaughtError methods to createRoot and hydrateRoot to customize this error handling.

Removed: propTypes: Using propTypes will now be silently ignored. If required, we recommend migrating to TypeScript or another type-checking solution.

Removed: defaultProps for functions: ES6 default parameters can be used in place. Class components continue to support defaultProps since there is no ES6 alternative.

Removed: contextTypes and getChildContext: Legacy Context for class components has been removed in favor of the contextType API.

... (truncated)

Changelog

Sourced from react-dom's changelog.

19.0.0 (December 5, 2024)

Below is a list of all new features, APIs, deprecations, and breaking changes. Read React 19 release post and React 19 upgrade guide for more information.

Note: To help make the upgrade to React 19 easier, we’ve published a react@18.3 release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19. We recommend upgrading to React 18.3.1 first to help identify any issues before upgrading to React 19.

New Features

React

Actions: startTransition can now accept async functions. Functions passed to startTransition are called “Actions”. A given Transition can include one or more Actions which update state in the background and update the UI with one commit. In addition to updating state, Actions can now perform side effects including async requests, and the Action will wait for the work to finish before finishing the Transition. This feature allows Transitions to include side effects like fetch() in the pending state, and provides support for error handling, and optimistic updates.

useActionState: is a new hook to order Actions inside of a Transition with access to the state of the action, and the pending state. It accepts a reducer that can call Actions, and the initial state used for first render. It also accepts an optional string that is used if the action is passed to a form action prop to support progressive enhancement in forms.

useOptimistic: is a new hook to update state while a Transition is in progress. It returns the state, and a set function that can be called inside a transition to “optimistically” update the state to expected final value immediately while the Transition completes in the background. When the transition finishes, the state is updated to the new value.

use: is a new API that allows reading resources in render. In React 19, use accepts a promise or Context. If provided a promise, use will suspend until a value is resolved. use can only be used in render but can be called conditionally.

ref as a prop: Refs can now be used as props, removing the need for forwardRef.

Suspense sibling pre-warming: When a component suspends, React will immediately commit the fallback of the nearest Suspense boundary, without waiting for the entire sibling tree to render. After the fallback commits, React will schedule another render for the suspended siblings to “pre-warm” lazy requests.

React DOM Client

<form> action prop: Form Actions allow you to manage forms automatically and integrate with useFormStatus. When a <form> action succeeds, React will automatically reset the form for uncontrolled components. The form can be reset manually with the new requestFormReset API.

<button> and <input> formAction prop: Actions can be passed to the formAction prop to configure form submission behavior. This allows using different Actions depending on the input.

useFormStatus: is a new hook that provides the status of the parent <form> action, as if the form was a Context provider. The hook returns the values: pending, data, method, and action.

Support for Document Metadata: We’ve added support for rendering document metadata tags in components natively. React will automatically hoist them into the <head> section of the document.

Support for Stylesheets: React 19 will ensure stylesheets are inserted into the <head> on the client before revealing the content of a Suspense boundary that depends on that stylesheet.

Support for async scripts: Async scripts can be rendered anywhere in the component tree and React will handle ordering and deduplication.

Support for preloading resources: React 19 ships with preinit, preload, prefetchDNS, and preconnect APIs to optimize initial page loads by moving discovery of additional resources like fonts out of stylesheet loading. They can also be used to prefetch resources used by an anticipated navigation.

React DOM Server

Added prerender and prerenderToNodeStream APIs for static site generation. They are designed to work with streaming environments like Node.js Streams and Web Streams. Unlike renderToString, they wait for data to load for HTML generation.

React Server Components

RSC features such as directives, server components, and server functions are now stable. This means libraries that ship with Server Components can now target React 19 as a peer dependency with a react-server export condition for use in frameworks that support the Full-stack React Architecture. The underlying APIs used to implement a React Server Components bundler or framework do not follow semver and may break between minors in React 19.x. See docs for how to support React Server Components.

Deprecations

Deprecated: element.ref access: React 19 supports ref as a prop, so we’re deprecating element.ref in favor of element.props.ref. Accessing will result in a warning.

react-test-renderer: In React 19, react-test-renderer logs a deprecation warning and has switched to concurrent rendering for web usage. We recommend migrating your tests to @testing-library/react or @testing-library/react-native

Breaking Changes

React 19 brings in a number of breaking changes, including the removals of long-deprecated APIs. We recommend first upgrading to 18.3.1, where we've added additional deprecation warnings. Check out the upgrade guide for more details and guidance on codemodding.

React

New JSX Transform is now required: We introduced a new JSX transform in 2020 to improve bundle size and use JSX without importing React. In React 19, we’re adding additional improvements like using ref as a prop and JSX speed improvements that require the new transform.

Errors in render are not re-thrown: Errors that are not caught by an Error Boundary are now reported to window.reportError. Errors that are caught by an Error Boundary are reported to console.error. We’ve introduced onUncaughtError and onCaughtError methods to createRoot and hydrateRoot to customize this error handling.

Removed: propTypes: Using propTypes will now be silently ignored. If required, we recommend migrating to TypeScript or another type-checking solution.

Removed: defaultProps for functions: ES6 default parameters can be used in place. Class components continue to support defaultProps since there is no ES6 alternative.

... (truncated)

Commits

989af12 Make prerendering always non-blocking with fix (#31452)
e137890 [string-refs] cleanup string ref code (#31443)
07aa494 Remove enableRefAsProp feature flag (#30346)
cae764c Revert "[Re-land] Make prerendering always non-blocking (#31268)" (#31355)
d49123f Expose prerender() for SSG in stable (#31298)
6c4bbc7 [Re-land] Make prerendering always non-blocking (#31268)
d8c90fa Disable infinite render loop detection (#31088)
67fee58 [Fizz] Start initial work immediately (#31079)
76aee6f Revert "Make prerendering always non-blocking" (#31080)
0f1856c Make prerendering always non-blocking (#31056)
Additional commits viewable in compare view

Updates @types/react from 18.3.14 to 19.0.1

Commits

See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the react-deps group with 3 updates in the / directory: [react](https://github.com/facebook/react/tree/HEAD/packages/react), [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) and [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom). Updates `react` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react) Updates `@types/react` from 18.3.14 to 19.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) Updates `react-dom` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react-dom) Updates `@types/react` from 18.3.14 to 19.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major dependency-group: react-deps - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major dependency-group: react-deps - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: react-deps - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major dependency-group: react-deps ... Signed-off-by: dependabot[bot] <support@github.com>

SgtPooki

JSX.Element was no longer global. changed all JSX.Element to ReactElement and fixed other type errors.. used React.FC where possible

SgtPooki · 2024-12-06T18:34:49Z

test:chrome is failing currently for some reason. it's passing locally within 21 seconds, but it failed once: https://github.com/ipfs/service-worker-gateway/actions/runs/12203903713/job/34047914482?pr=518#step:6:765 and then the retry is taking a while (7m currently) too

SgtPooki · 2024-12-09T15:56:34Z

@lidel would you mind attempting to run npm run test:chrome on your linux machine? I can't repro this locally and the CI output isn't giving us much to go off of

lidel · 2024-12-09T16:30:21Z

Interesting, passed for me locally, must be specific to github ubuntu image or npx playwright install --with-deps (I don't use ubuntu and only used npx playwright install)

lidel · 2024-12-09T19:46:07Z

My bad, I tested against old build.

Run npm ci && npm run build && npm run test:chrome and it fails on came 2 cases as CI.

I've opened #521 to see if we can bump playwright just to be sure its not a solved problem, but CI there also failed, need to check on it tomorrow.

Running 22 tests using 4 workers

  ✓  1 [chromium] › byte-range.test.ts:23:3 › byte-ranges › can get trailing byte range from car with missing data (1.5s)
  ✓  2 [chromium] › byte-range.test.ts:14:3 › byte-ranges › can get 0-0 byte range from car with missing data (1.3s)
  ✓  3 [chromium] › config-loading.test.ts:27:3 › ipfs-sw configuration › setting the config actually works (1.6s)
  ✓  4 [chromium] › byte-range.test.ts:5:3 › byte-ranges › should be able to get a single character (1.1s)
[WebServer] (node:22585) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
[WebServer] (Use `node --trace-deprecation ...` to show where the warning was created)
  ✓  5 [chromium] › config-loading.test.ts:35:3 › ipfs-sw configuration › root config is propagated to subdomain (2.0s)
  ✓  6 [chromium] › first-hit.test.ts:33:5 › first-hit ipfs-hosted › subdomain-routing › redirects to ?helia-sw=<path> are handled (1.4s)
  ✓  7 [chromium] › first-hit.test.ts:84:5 › first-hit direct-hosted › subdomain-routing › requests to new pages are redirected (1.9s)
  ✓  8 [chromium] › first-hit.test.ts:13:5 › first-hit ipfs-hosted › path-routing › redirects to ?helia-sw=<path> are handled (1.0s)
  ✓  9 [chromium] › first-hit.test.ts:66:5 › first-hit direct-hosted › path-routing › requests to new pages are redirected (1.1s)
  ✓  10 [chromium] › hamt-dir.test.ts:4:3 › hamt-dir › can open UnixFS file from HAMT-sharded directory (1.7s)
  ✓  11 [chromium] › layout.test.ts:11:5 › smoketests › landing page › header visibility (581ms)
  ✓  12 [chromium] › layout.test.ts:20:5 › smoketests › config section › displays on landing page (505ms)
  ✓  13 [chromium] › layout.test.ts:25:5 › smoketests › config section › has multiple inputs and submit button (695ms)
  ✓  14 [chromium] › layout.test.ts:40:5 › smoketests › config section on subdomains › only config and header are visible on /#/ipfs-sw-config requests (2.4s)
  -  15 [chromium] › no-service-worker.test.ts:5:3 › no-service-worker › Error renders on landing page
  -  16 [chromium] › no-service-worker.test.ts:11:3 › no-service-worker › Error renders on subdomain page
  ✓  17 [chromium] › path-routing.test.ts:4:3 › path-routing › can load identity CID via path (1.5s)
  ✓  18 [chromium] › subdomain-detection.test.ts:63:3 › subdomain-detection auto fixture › loads subdomains easily (2.6s)
  ✓  19 [chromium] › subdomain-detection.test.ts:15:3 › subdomain-detection › path requests are redirected to subdomains (2.3s)
  ✓  20 [chromium] › subdomain-detection.test.ts:42:3 › subdomain-detection › enabling autoreload automatically loads the subdomain (1.6s)
  ✓  21 [chromium] › website-loading.test.ts:4:3 › website-loading › ensure unixfs directory trailing slash is added (1.1s)
  ✘  22 [chromium] › website-loading.test.ts:12:3 › website-loading › ensure that index.html is returned for the root path (30.0s)


  1) [chromium] › website-loading.test.ts:12:3 › website-loading › ensure that index.html is returned for the root path

    Test timeout of 30000ms exceeded while setting up "page".

    Error: page.evaluate: Test timeout of 30000ms exceeded.

       at fixtures/wait-for-service-worker.ts:4

      2 |
      3 | export async function waitForServiceWorker (page: Page): Promise<void> {
    > 4 |   await page.evaluate(async () => {
        |              ^
      5 |     const registration = await window.navigator.serviceWorker.getRegistration()
      6 |
      7 |     if (registration?.active?.state === 'activated') {
        at waitForServiceWorker (/home/lidel/project/ipfs/service-worker-gateway/test-e2e/fixtures/wait-for-service-worker.ts:4:14)
        at Object.page (/home/lidel/project/ipfs/service-worker-gateway/test-e2e/fixtures/config-test-fixtures.ts:46:11)

  1 failed
    [chromium] › website-loading.test.ts:12:3 › website-loading › ensure that index.html is returned for the root path
  2 skipped
  19 passed (1.1m)

dependabot bot added the dependencies Pull requests that update a dependency file label Dec 6, 2024

chore: fix react types after dep update

fe836d3

SgtPooki approved these changes Dec 6, 2024

View reviewed changes

chore: package-lock.json update after reset

66ce5d6

lidel mentioned this pull request Dec 10, 2024

chore: playwright update #521

Draft

3 tasks

SgtPooki added 2 commits December 12, 2024 14:30

Merge branch 'main' into dependabot/npm_and_yarn/react-deps-b6b6fabfc0

9e44fe3

chore: fix package-lock.json

09717f6

SgtPooki approved these changes Dec 12, 2024

View reviewed changes

SgtPooki merged commit 66e0857 into main Dec 12, 2024
16 checks passed

SgtPooki deleted the dependabot/npm_and_yarn/react-deps-b6b6fabfc0 branch December 12, 2024 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: bump the react-deps group across 1 directory with 3 updates #518

deps: bump the react-deps group across 1 directory with 3 updates #518

dependabot bot commented on behalf of github Dec 6, 2024 •

edited

Loading

SgtPooki left a comment

SgtPooki commented Dec 6, 2024

SgtPooki commented Dec 9, 2024

lidel commented Dec 9, 2024 •

edited

Loading

lidel commented Dec 9, 2024 •

edited

Loading

deps: bump the react-deps group across 1 directory with 3 updates #518

deps: bump the react-deps group across 1 directory with 3 updates #518

Conversation

dependabot bot commented on behalf of github Dec 6, 2024 • edited Loading

19.0.0 (December 5, 2024)

New Features

React

React DOM Client

React DOM Server

React Server Components

Deprecations

Breaking Changes

React

19.0.0 (December 5, 2024)

New Features

React

React DOM Client

React DOM Server

React Server Components

Deprecations

Breaking Changes

React

19.0.0 (December 5, 2024)

New Features

React

React DOM Client

React DOM Server

React Server Components

Deprecations

Breaking Changes

React

19.0.0 (December 5, 2024)

New Features

React

React DOM Client

React DOM Server

React Server Components

Deprecations

Breaking Changes

React

SgtPooki left a comment

Choose a reason for hiding this comment

SgtPooki commented Dec 6, 2024

SgtPooki commented Dec 9, 2024

lidel commented Dec 9, 2024 • edited Loading

lidel commented Dec 9, 2024 • edited Loading

dependabot bot commented on behalf of github Dec 6, 2024 •

edited

Loading

lidel commented Dec 9, 2024 •

edited

Loading

lidel commented Dec 9, 2024 •

edited

Loading