Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPIP: Streaming Delegated Content Routing #344

Closed
guseggert opened this issue Nov 15, 2022 · 1 comment · Fixed by #410
Closed

IPIP: Streaming Delegated Content Routing #344

guseggert opened this issue Nov 15, 2022 · 1 comment · Fixed by #410
Assignees
Labels
IPIP (InterPlanetary) Improvement Proposal kind/enhancement A net-new feature or an improvement to an existing feature P1 High: Likely tackled by core team if no one steps up

Comments

@guseggert
Copy link
Contributor

To support DHT use cases, the Delegated Content Routing HTTP API needs to support a streaming response that streams providers as they are found, probably using an application/x-ndjson response format.

@guseggert guseggert added P1 High: Likely tackled by core team if no one steps up kind/enhancement A net-new feature or an improvement to an existing feature IPIP (InterPlanetary) Improvement Proposal labels Nov 15, 2022
@guseggert guseggert self-assigned this Nov 15, 2022
@guseggert
Copy link
Contributor Author

guseggert commented May 9, 2023

This is implemented and tested in ipfs/boxo#18.

A note on errors:

To match the existing content routing interface (which does not support any sort of errors), the schema does not allow for passing per-record errors. The schema does allow for adding per-record errors to the struct if a future use-case arises for that.

If there is an unrecoverable error before streaming begins, then the server can send an HTTP error status code, otherwise if the server has started streaming the response and encounters an unrecoverable error, then it must terminate the connection to signal an error.

@hacdias hacdias self-assigned this May 12, 2023
lidel added a commit that referenced this issue Jun 15, 2023
IPIP-410: Streaming Routing V1 HTTP API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IPIP (InterPlanetary) Improvement Proposal kind/enhancement A net-new feature or an improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants