Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Gateway Specs #283
Add HTTP Gateway Specs #283
Changes from 4 commits
a28d1de
6e24eb0
2e4374f
101fa5e
7be0611
6a0e2fc
13f53a8
a414411
af0363e
4156b43
5435910
176133a
cad7046
04111e6
ce193e6
ffe8af9
7e65a76
e3637e5
2c731d3
6787fd8
25497a4
4b57971
75543c3
849a7e3
e06249f
9fc9a9c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we define that:
/ipns
path must be resolved to an immutable path first...path before appending the request path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olizilla I've added this + note about recursion limit + an example in 7be0611 – lmk if that covers all the bases