Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed v2 of the IPIP process #324

Merged
merged 5 commits into from
Oct 23, 2022
Merged

Proposed v2 of the IPIP process #324

merged 5 commits into from
Oct 23, 2022

Conversation

reidlw
Copy link
Contributor

@reidlw reidlw commented Sep 22, 2022

Proposing some restructuring, rewording, and more structured consensus protocol for moving proposals through the process

@reidlw reidlw requested a review from a team as a code owner September 22, 2022 18:04
@reidlw
Copy link
Contributor Author

reidlw commented Sep 22, 2022

@p-shahi take a look! :)

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sgtm, this follows our long term plan for IPIPs.

IPIPs aim to be immutable, but this one is special, because it acts as an entry point for people new to this repo. I think it should point at "current best practices"

Would it make sense to copy this content and create IPIP-specification-process.md in the root of this repo (similar to libp2p/specs/00-framework-01-spec-lifecycle.md ) and point both README.md and this original IPIP0001 at this new living document?

This way we will not overwrite historical IPIP, and make the current process easier to discover.

IPIP/0001-lightweight-improvement-proposal-process.md Outdated Show resolved Hide resolved
IPIP/0001-lightweight-improvement-proposal-process.md Outdated Show resolved Hide resolved
IPIP/0001-lightweight-improvement-proposal-process.md Outdated Show resolved Hide resolved
IPIP/0001-lightweight-improvement-proposal-process.md Outdated Show resolved Hide resolved
IPIP/0001-lightweight-improvement-proposal-process.md Outdated Show resolved Hide resolved
@guseggert guseggert added this to the Best Effort Track milestone Oct 13, 2022
@guseggert guseggert added the P1 High: Likely tackled by core team if no one steps up label Oct 13, 2022
reidlw and others added 3 commits October 13, 2022 19:37
Proposing some restructuring, rewording, and more structured consensus protocol for moving proposals through the process
This keeps historical record intact, and points at mutable process
at the repo root.
@lidel lidel force-pushed the reidlw/process-proposal branch from 36684f2 to 9f295c5 Compare October 13, 2022 17:41
@lidel lidel changed the title Proposed v2 of the IPIP doc Proposed v2 of the IPIP process Oct 13, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidlw fysa I've rebased this PR and moved v2 to IPIP_PROCESS.md, so we are not mutating historical IPIP (+ made it link to the file as the upt-to-date source of truth about the process).

I think this is ready to merge, we can adjust in follow-up PRs, but let's discuss this during today's IPFS Implementers Sync


1. [Specs Stewards] will do an initial triage of newly opened PRs roughly monthly. They'll try to filter out
noise, so that community consideration is given only to reasonable proposals; others they'll reject.
2. Specs Stewards will post to the forums linking to the proposal; directing feedback/discussion to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we mean by "the forums"?
Should I create "IPIP" category under https://discuss.ipfs.tech/c/protocol/30 ?

IPIP_PROCESS.md Outdated

Proposals are officially submitted when a pull request into `main` is opened

Proposals that were reviewed and rejected will be moved into `IPIP/rejected` folder and then merged into `main`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since things that are rejected immediately won't be merged, and we only merge "potentially useful" proposals,
should it be "rejected" or more neutral "deferred" ?

5. Proposals that are generating ongoing discussion and seem contentious or stuck will be brought in for
consideration at a monthly sync, to be announced at least a week ahead of time on the forum.
6. After discussion, Spec Stewards will make call on whether to approve or reject the proposal.
7. At this point approved proposals get assigned a number (encoded in the filename),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: could we assign number earlier, during initial evaluation as suggested in #303 ?

@lidel
Copy link
Member

lidel commented Oct 23, 2022

Made changes suggested during last IPFS Implementers Sync, merging.

Thank you @reidlw!
Let's continue in #303 and #291

@lidel lidel merged commit 6d68785 into main Oct 23, 2022
@lidel lidel deleted the reidlw/process-proposal branch October 23, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants