chore: fix broken link in IPIP-337 #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added up to date details regarding reframe which are referenced in this spec to reflect the current deprecated state of Reframe to reduce confusion.
Noticed a sentence I'd duplicated and revised it to make note of the 'Routing V1' title referenced here: ipfs/kubo#9479
lidel
requested changes
Apr 3, 2023
There was a problem hiding this comment.
@TorfinnOlsen thank you for submitting this. IPIPs are meant to be historical documents, they explain decision and state made at specific point in time. We want reader to be able to see Reframe looked at the time.
We do not want to rewrite history books here. At the time, afaik, we did not plan to fully kill Reframe, we just wanted a simpler API until Reframe gets proper resourcing.
As it turned out, nobody at PL, nor wider IPFS ecosystem cared to pick up Reframe, so the removal decision was made later (specs, Kubo).
If you want to fix the broken link, perhaps change this PR to be just below?
- The [Reframe spec](https://github.com/ipfs/specs/blob/main/reframe/REFRAME_PROTOCOL.md) for delegated content routing is an experimental attempt at this,
+ The [Reframe spec](https://github.com/ipfs/specs/tree/ed02df474c18eb9fa1d5bb2aeecb05209102c373/reframe) for delegated content routing is an experimental attempt at this,
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose to update Delegated Content Routing Spec IPIP-337 to include up to date information regarding the deprecation of reframe in alignment with @guseggert efforts documented here.