libp2p - [WIP] Update the Interfaces chapter #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
changed the title
daviddias
changed the title
| // PeerID is a hash of a PublicKey, encoded in multihash | ||
| // It represents the identity of a node. | ||
| type PeerID Multihash | ||
| https://github.com/diasdavid/js-libp2p-swarm#usage |
There was a problem hiding this comment.
@jbenet @whyrusleeping would you like to bikeshed a bit these function calls? Same goes for the "abstract-", so that they get written on the spec and making everyone happy
|
|
||
| type PublicKey interface { | ||
| PeerID() PeerID | ||
| https://github.com/diasdavid/js-libp2p-swarm#usage |
There was a problem hiding this comment.
@jbenet @whyrusleeping would you like to bikeshed a bit these function calls? Same goes for the "abstract-", so that they get written on the spec and making everyone happy
| @@ -1,139 +1,99 @@ | |||
| 6 Interfaces | |||
| ============ | |||
|
|
|||
| `libp2p` is a conglomerate of several protocols working together to offer a common solid interface with talking with any other network addressable process. This is made possible by shimming current exist protocols and implementations through a set of explicit interfaces, from Peer Routing, Discovery, Stream Muxing, Transports, Connections and so on. | |||
There was a problem hiding this comment.
maybe s/conglomerate/collection. though very accurate, "conglomerate" has bad connotations (evil conglomerate megacorps)
daviddias
added a commit
that referenced
this pull request
Dec 12, 2015
libp2p - [WIP] Update the Interfaces chapter
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.