Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Create 2018-12-12--gui-and-in-web-browsers-weekly.md #805

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 13, 2018

cc #790

@ghost ghost assigned lidel Dec 13, 2018
@ghost ghost added the status/in-progress In progress label Dec 13, 2018
- Next:
- 2 more usability testing session for webui. write up the common issues. Propose next round of improvements to webui
- Refactoring to webui and ipfs-redux-bundle to work with the api changes in ipfs-http-client \*\*help wanted\*\*
- Refactoring ipld-explorer-components to work with changes to dag-pb and ipld apis. \*\*help wanted\*\* (good opportunity to pair on ipld-explorer code.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be available on Monday and Tuesday to help with this - updated WebUI blocks JS IPFS 0.34 release right now and I wanted it to happen this year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @olizilla wants to do some bigger refactoring, though there's also ipfs/ipld-explorer-components#6 which made things work for the dag-cbor API change (at least AFAICT).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of note, Web UI is using older versions of js-ipld and js-ipfs-api (the lib formally known as). Right now, as long as I don't upgrade ipld, Web UI still works as intended, which is what I'd expect. I will need to upgrade the ipld explrorer UI when I take the new ipld lib, but I expect it to keep working until i do.

Same goes for the file api from js-ipfs. I'd assume that older clients would still be able to access the http api in the same way, and new clients would use the new way. Or is this a breaking change to the http api too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no (intended) breaking change to the HTTP API.

To be honest, I used it on the DHT branch and got a blank page for the files page...I didn't look into it any further at the time, so it just needs some investigation. I initially thought it was because of the breaking core API changes but as @olizilla pointed out the WebUI is bundled with it's dependencies, so should still work (since there's no HTTP API breaks).

- I was blocked by laryngitis. I’,m on the mend now.
- Next:
- 2 more usability testing session for webui. write up the common issues. Propose next round of improvements to webui
- Refactoring to webui and ipfs-redux-bundle to work with the api changes in ipfs-http-client \*\*help wanted\*\*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tackle this one.

@lidel lidel merged commit 0b8f996 into master Dec 17, 2018
@ghost ghost removed the status/in-progress In progress label Dec 17, 2018
@lidel lidel deleted the 2018-12-12--gui-and-in-web-browsers-weekly branch December 17, 2018 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants