Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forEach iterates over index in stable order #258

Merged
merged 3 commits into from
Oct 16, 2021
Merged

forEach iterates over index in stable order #258

merged 3 commits into from
Oct 16, 2021

Conversation

willscott
Copy link
Member

No description provided.

@willscott willscott requested a review from masih October 16, 2021 18:26
This was referenced Oct 16, 2021
Closed
Merged
mvdan
mvdan approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and docs SGTM :) Just one nit to make the test more robust.

v2/index/mhindexsorted_test.go Show resolved Hide resolved
@willscott willscott merged commit f9c3b06 into master Oct 16, 2021
@willscott willscott deleted the stableinterate branch October 16, 2021 23:26
rvagg pushed a commit that referenced this pull request Oct 22, 2021
@willscott @rvagg
forEach iterates over index in stable order (#258)
d5ab3c5 
* forEach iterates over index in stable order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@masih masih Awaiting requested review from masih masih is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willscott @mvdan