make specification of root cid in get-dag command optional #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a test script
mvdan
approved these changes
Jan 6, 2022
cmd/car/testdata/script/get.txt
Outdated
| @@ -0,0 +1,6 @@ | |||
| env SAMPLE_CID='bafy2bzaceaycv7jhaegckatnncu5yugzkrnzeqsppzegufr35lroxxnsnpspu' | |||
There was a problem hiding this comment.
following the other files, shouldn't we call this get-dag.txt?
if you prefer get.txt, then I'd join get-block.txt here.
There was a problem hiding this comment.
the go file under test is get.go which has both get-block and get-dag. what do you think is more reasonable?
There was a problem hiding this comment.
If you expect the test scripts to grow further, I'd keep them separate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a test script