Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read buffers wherever ReadByte() is called repeatedly #334

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add read buffers wherever ReadByte() is called repeatedly #334

wants to merge 1 commit into from

Conversation

dirkmc
Copy link

@dirkmc dirkmc commented Sep 22, 2022

No description provided.

@dirkmc dirkmc force-pushed the feat/read-buffering branch 2 times, most recently from 3e84623 to 25c9823 Compare September 22, 2022 12:34
@dirkmc dirkmc changed the title Add read buffers wherever ReadByte() is called Add read buffers wherever ReadByte() is called repeatedly Sep 22, 2022
@willscott
Copy link
Member

would there be a way to avoid this extra layer of bufio copies for cases where the backing ReaderAt passed to the car library is already a memory buffer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg Awaiting requested review from rvagg rvagg will be requested when the pull request is marked ready for review rvagg is a code owner

@willscott willscott Awaiting requested review from willscott willscott will be requested when the pull request is marked ready for review willscott is a code owner

@masih masih Awaiting requested review from masih masih will be requested when the pull request is marked ready for review masih is a code owner

@hannahhoward hannahhoward Awaiting requested review from hannahhoward hannahhoward will be requested when the pull request is marked ready for review hannahhoward is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @willscott