Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Check for byte buffer on decode #3

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

hannahhoward
Copy link
Collaborator

See slack message about mem allocations and io.ReadAll

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #3 into master will increase coverage by 0.98%.
The diff coverage is 84.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   22.24%   23.22%   +0.98%     
==========================================
  Files           7        7              
  Lines         787      797      +10     
==========================================
+ Hits          175      185      +10     
  Misses        596      596              
  Partials       16       16              
Impacted Files Coverage Δ
coding.go 82.72% <84.62%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ffdad...80b2e49. Read the comment docs.

@rvagg
Copy link
Member

rvagg commented Aug 28, 2020

might be a good chance to get @mvdan in here to help with reviews

Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, though I'm not sure why these funcs take an io.Reader if we just grab the entire buffer all at once. This would be much more straightforward and performant if it took a []byte directly.

@hannahhoward hannahhoward merged commit ae0aea0 into master Aug 28, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants