Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enumerate methods for the multicodec registries #169

Closed
wants to merge 1 commit into from
Closed

Add enumerate methods for the multicodec registries #169

wants to merge 1 commit into from

Conversation

willscott
Copy link
Member

Adds ListDecoders and ListEncoders methods to learn which multicodecs have been registered with encoders/decoders.

@willscott willscott requested a review from warpfork May 14, 2021 06:14
@willscott willscott mentioned this pull request May 19, 2021
Merged
mvdan
mvdan approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

warpfork pushed a commit that referenced this pull request May 24, 2021
@willscott @warpfork
Add enumerate methods to the multicodec registries.
401e218 
(This is a logical port of
#169 to follow
#172 .)

I've added more documentation -- particularly, cautionary notes on the
package-scope functions which read the global shared state.
@warpfork warpfork mentioned this pull request May 25, 2021
Merged
@warpfork
Copy link
Collaborator

Supplanted by #176, which contained the same effects.

@warpfork warpfork closed this May 25, 2021
@warpfork warpfork deleted the feat/enumeratemulticodecs branch May 25, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@warpfork warpfork Awaiting requested review from warpfork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willscott @warpfork @mvdan