linking: add LoadRaw and LoadPlusRaw functions to LinkSystem. #267
Conversation
|
|
These allow getting raw byte slices back along with the processed Node, or just the raw byte slice alone. Also added a great deal of documentation, including to existing functions which were lacking it.
| return nil, ErrLinkingSetup{"could not choose a hasher", err} | ||
| } | ||
| if lsys.StorageReadOpener == nil { | ||
| return nil, ErrLinkingSetup{"no storage configured for reading", io.ErrClosedPipe} // REVIEW: better cause? |
There was a problem hiding this comment.
REVIEW: nah, this is a good enough cause
There was a problem hiding this comment.
👌 is good, should solve @willscott's problem @ https://github.com/ipfs/go-unixfsnode/pull/12/files#diff-e7601536d9fbbbc73c6e0384fbd5db1d2acc4cdf253ecc100bddbbbd15c3d799R155
|
With a lack of complaints, okay, merging :) Note that I still consider the method names a little tentative, and possibly worth iterating on; I'll consider them stable after we start seeing them used, not before. There may be more PRs touching this area in the next smallnum days :) |
The new
LoadRawandLoadPlusRawfunctions allow getting raw byte slices back along with the processed Node, or just the raw byte slice alone.These behaviors can be useful if you're building an application which both loads the data and processes it, and also needs to pass on the serial form at the same time.
(Also added a great deal of documentation, including to existing functions which were lacking it.)