Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toInterface #304

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Add toInterface #304

merged 5 commits into from
Dec 2, 2021

Conversation

MarcoPolo
Copy link
Contributor

Fixes #178

Does this seem like the general idea you were thinking of @mvdan? If so I'll add more documentation and maybe a couple more test cases.

mvdan
mvdan reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The comments are mostly minor.

fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
@MarcoPolo MarcoPolo changed the title [wip] Add toInterfaceValue Add toInterface Nov 30, 2021
@MarcoPolo MarcoPolo marked this pull request as ready for review November 30, 2021 03:20
@MarcoPolo MarcoPolo requested a review from mvdan November 30, 2021 03:20
mvdan
mvdan approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor nits, we can merge when they're addressed.

fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue.go Show resolved Hide resolved
fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
fluent/toInterfaceValue_test.go Outdated Show resolved Hide resolved
@MarcoPolo
Copy link
Contributor Author

Thanks for the great comments @mvdan

@MarcoPolo MarcoPolo requested a review from mvdan November 30, 2021 15:10
mvdan
mvdan approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@mvdan mvdan merged commit dc30274 into ipld:master Dec 2, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 8, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fluent: provide an API to convert an ipld.Node to a generic Go value
2 participants
@MarcoPolo @mvdan