fix(bindnode): panic early if API has been passed ptr-to-ptr #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
May 23, 2022
masih
added a commit
to filecoin-project/go-data-transfer
that referenced
this pull request
Jun 15, 2022
Bindnode wrap expects a pointer. A fail-fast check is introduced in ipld/go-ipld-prime#427 which will cause a panic if the IPLD dependency is upgraded to the head of main branch. Avoid passing pointer-to-pointer when wrapping transfer message. See: - ipld/go-ipld-prime#427
masih
added a commit
to filecoin-project/go-data-transfer
that referenced
this pull request
Jun 16, 2022
Bindnode wrap expects a pointer. A fail-fast check is introduced in ipld/go-ipld-prime#427 which will cause a panic if the IPLD dependency is upgraded to the head of main branch. Avoid passing pointer-to-pointer when wrapping transfer message. See: - ipld/go-ipld-prime#427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.