-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updates for latest multiformats #7
Conversation
this is against multiformats/js-multiformats#70, so won't pass until that's published |
Here is the module resolution trace from TS:
Looks like it does typeVersions resolution twice and fails to resolve for that reason, which reminds me of the that or similar issue I've reported in the past microsoft/TypeScript#41284 Now that we know what is failing, we can try finding a work around |
I have tried my best to get this resolved but it seems there is a combination of bugs that either breaks js-car or breaks ts-use example in js-multiformats. If we do use If we do not use If we do use At this point I'm not sure if there is a reasonable way to get any of this to work |
Found a workaround and submitted multiformats/js-multiformats#72 |
Pulled in the enhancement from #8 to here, also copied an additional enhancement from multiformats/js-multiformats#70 that fixes the Will update when multiformats/js-multiformats#70 is done and copy the same enhancements to the codecs. |
This is passing now with multiformats@6.0.0 as per multiformats/js-multiformats#70 I'm pretty happy with the pattern emerging here, it seems to be ticking the boxes we care about as far as I can tell. |
73e64d9
to
e68cfb8
Compare
e68cfb8
to
554b0f2
Compare
updated to today's multiformats and codecs, removed a bunch of ts-ignores, expanded typing checking and improved the published version a little 🤞 |
this needs the newer types dist changes migrated from multiformats when finalised there