feat: support decoding ArrayBuffers #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands supported input types to include `ArrayBuffer`s to make it easiser for users to use modules like `fetch` that don't return `Uint8Array`s.
|
@rvagg I'm not sure if you'd like a PR to |
rvagg
reviewed
Feb 16, 2024
rvagg
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
same concern as ipld/js-dag-json#127 (review) but not strong enough to reject
just needs that lint thing fixed and green CI
at this stage I think doing it here is appropriate, let's think about pushing it down further if the need arises.
Co-authored-by: Rod Vagg <rod@vagg.org>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
## [9.2.0](v9.1.0...v9.2.0) (2024-02-16) ### Features * support decoding ArrayBuffers ([#114](#114)) ([a10269d](a10269d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands supported input types to include
ArrayBuffers to make it easiser for users to use modules likefetchthat don't returnUint8Arrays.