This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Serialize Uint8Array as binary (like Buffer) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeal
approved these changes
Jun 9, 2020
6 tasks
|
belated +1, very nice |
rvagg
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
Jun 11, 2020
Not strictly necessary but this test was added to ipld-dag-cbor and it's nice for completeness and holds us strictly to the promise of Uint8Arrays being the primary byte holder Ref: ipld/js-ipld-dag-cbor#129
mikeal
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
Jun 13, 2020
BREAKING CHANGE! * feat: migrate code * wip: needs more coverage * fix: make clean Uint8Array * fix: 100% coverage, backing out error swallowing * build: automated releases * fix: linter fixes * chore: pull in Uint8Array|Buffer test Not strictly necessary but this test was added to ipld-dag-cbor and it's nice for completeness and holds us strictly to the promise of Uint8Arrays being the primary byte holder Ref: ipld/js-ipld-dag-cbor#129 * fix: move constants to top * fix: upgrade to latest ESM version Co-authored-by: Rod Vagg <rod@vagg.org>
mikeal
pushed a commit
to ipld/js-dag-cbor
that referenced
this pull request
Jun 18, 2020
Not strictly necessary but this test was added to ipld-dag-cbor and it's nice for completeness and holds us strictly to the promise of Uint8Arrays being the primary byte holder Ref: ipld/js-ipld-dag-cbor#129
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #128 this change treats
Uint8Arrayjust as it treatsBuffer, which also happens to match underlying borc implementation:https://github.com/dignifiedquire/borc/blob/master/src/encoder.js#L406-L407