This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Awesome IPLD endeavour #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
awesome-ipld
branch
from
4152f66 to
5b74609
Compare
| value: flatObj[key] | ||
| } | ||
| }) | ||
| return paths |
There was a problem hiding this comment.
you can just immediately return the result, instead of creating a variable
| continue | ||
| } | ||
| // Exclude arrays from the final result | ||
| if (flatObject[x] && Array === flatObject.constructor) { |
There was a problem hiding this comment.
you can use Array.isArray
daviddias
force-pushed
the
awesome-ipld
branch
3 times, most recently
from
d296603 to
4bc69d2
Compare
36 tasks
daviddias
force-pushed
the
awesome-ipld
branch
from
4bc69d2 to
72db4fd
Compare
dignifiedquire
suggested changes
Oct 24, 2016
| "version": "0.6.0", | ||
| "description": "JavaScript implementation of the IPLD (InterpPlanetary Linked Data)", | ||
| "main": "lib/index.js", | ||
| "main": "src/index.js", |
There was a problem hiding this comment.
TODO: remove before merge
| 'use strict' | ||
|
|
||
| const util = require('./util') | ||
| const _times = require('lodash.times') |
| // out of scope | ||
|
|
||
| // TODO this was my first try at writting this out of scope traversal code, | ||
| // it REALLY needs way more testing. |
There was a problem hiding this comment.
It is :( Doesn't make it incorrect though
| const flatObj = flattenObject(node) | ||
| const paths = Object.keys(flatObj) | ||
| .map((key) => { | ||
| return { |
There was a problem hiding this comment.
this is some odd indenation
|
|
||
| describe('node', () => { | ||
| describe.skip('resolver.resolve', () => { | ||
| it('path', () => { |
There was a problem hiding this comment.
what about tests for these things?
| }, { | ||
| path: 'array/1', | ||
| value: '2' | ||
| } */]) |
There was a problem hiding this comment.
should be probably fixed before merge?
daviddias
force-pushed
the
awesome-ipld
branch
from
8ee153c to
b0e9d41
Compare
daviddias
force-pushed
the
awesome-ipld
branch
from
b0e9d41 to
0192c56
Compare
daviddias
force-pushed
the
awesome-ipld
branch
from
0192c56 to
b7a565b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.