This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Add ethereum resolvers #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The security failure is from a dep of aegir in the various ipld resolvers -- will bump |
22 tasks
daviddias
approved these changes
Feb 11, 2017
daviddias
suggested changes
Feb 11, 2017
test/ipld-eth-star.js
Outdated
| const expect = require('chai').expect | ||
| const rlp = require('rlp') | ||
| const BlockService = require('ipfs-block-service') | ||
| const cidForHash = require('ipld-eth-block/src/common').cidForHash |
There was a problem hiding this comment.
This is an anti-pattern, let's make avoid using paths and dots in conjunction. (preferably just dots)
Also, seems that cidForHash is used to calculate all the CIDs, can we have this as a module on npm eth-hash-to-cid, ideally even exports a CLI so that it is super easy to use.
daviddias
approved these changes
Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #71