feat: HAMT sharded directories #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
approved these changes
Mar 13, 2023
src/sharded-directory.js
Outdated
| * Facade for PersistentHashMap that implements Map. | ||
| * @implements {Map<string, API.EntryLink>} | ||
| */ | ||
| class HAMTMap { |
There was a problem hiding this comment.
Is this only to add mutability ? If so you could use a builder API instead
src/directory/api.ts
Outdated
| @@ -82,7 +82,7 @@ export interface View<Layout extends unknown = unknown> extends Writer<Layout> { | |||
| readonly writer: BlockWriter | |||
| readonly settings: EncoderSettings<Layout> | |||
|
|
|||
| links(): IterableIterator<DirectoryEntryLink> | |||
| links(): IterableIterator<DirectoryEntryLink> | AsyncIterableIterator<DirectoryEntryLink> | |||
There was a problem hiding this comment.
I really don't want to introduce things that will start doing work like encoding blocks. Unless I'm mistaken links() here is not really needed outside the writer implementation & if so I would much rather remove this method form here.
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates
@perma/mapto allow HAMT sharded directories to be created.In this PR there's no automated switch to HAMT, the consumer needs to explicitly use
createShardedDirectoryWriterto build one.