Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only send one newline after each record #32

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: only send one newline after each record #32

merged 1 commit into from
May 16, 2023

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented May 16, 2023

Each Line is a Valid JSON Value - (http://ndjson.org/)

Right now there's empty lines.

json.Encoder.Encode already adds a newline after each record: https://pkg.go.dev/encoding/json#Encoder.Encode

@hacdias hacdias marked this pull request as ready for review May 16, 2023 12:46
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a011dbc) 0.92% compared to head (09500e7) 0.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   0.92%   0.93%           
=====================================
  Files         10      10           
  Lines        757     749    -8     
=====================================
  Hits           7       7           
+ Misses       749     741    -8     
  Partials       1       1           
Impacted Files Coverage Δ
caskadht.go 0.00% <ø> (ø)
response_writer_dr.go 0.00% <ø> (ø)
response_writer_ipni.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masih
Copy link
Member

masih commented May 16, 2023

Thanks @hacdias 👍

@masih masih merged commit 4ab8860 into ipni:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants