Add send total timeout and use dedicated context for metrics #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a total timeout for a single cycle of broadcast. This is to make sure that the entire broadcast batch is either sent or wiped clean if it cannot be sent. The previous mechanism had timeouts implicitly inside bitswap implementation. The changes here add an explicit timeout to the context used across send. Use a separate background context for metrics to assure that metrics are collected even if context expires. This is to avoid room for odd numbers being reported by metrics.
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Jun 9, 2023
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a total timeout for a single cycle of broadcast. This is to make sure that the entire broadcast batch is either sent or wiped clean if it cannot be sent. The previous mechanism had timeouts implicitly inside bitswap implementation. The changes here add an explicit timeout to the context used across send.
Use a separate background context for metrics to assure that metrics are collected even if context expires. This is to avoid room for odd numbers being reported by metrics.