Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create syncer if already at stopnode #173

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

gammazero
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.07%. Comparing base (69d23c7) to head (bcf9245).

Files Patch % Lines
dagsync/subscriber.go 55.55% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   53.87%   54.07%   +0.19%     
==========================================
  Files          60       60              
  Lines        5041     5041              
==========================================
+ Hits         2716     2726      +10     
+ Misses       2028     2019       -9     
+ Partials      297      296       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit c028218 into main Mar 28, 2024
7 checks passed
@gammazero gammazero deleted the no-sync-client-at-stopnode branch March 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants