Make backend CB individually configurable and separate cascade #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor backend instantiation such that circuit breaker backends are individually configurable. Reflect changes across the repo. Add the ability to check if a backend matches a request before attempting to call it. This avoids response slow-down caused by slow backends early in the chain Introduce a separate configuration to mark cascade lookup backends with explicit matcher in order to avoid routing all requests to them. Relates to: - #86
masih
force-pushed
the
masih/cb_per_backend
branch
from
5b9d1d9 to
9c8b29f
Compare
willscott
approved these changes
Feb 23, 2023
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Feb 23, 2023
Fix client timeout to be maximum of streamin/nonstreaming timeout. Reduce non-streaming timeout to 2 seconds in order to reduce downstream timeouts for clients. If a backend is slower than 2 seconds it is already too slow and users should use streaming response instead. See: - ipni/indexstar#87
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Feb 23, 2023
Fix client timeout to be maximum of streamin/nonstreaming timeout. Reduce non-streaming timeout to 2 seconds in order to reduce downstream timeouts for clients. If a backend is slower than 2 seconds it is already too slow and users should use streaming response instead. See: - ipni/indexstar#87
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Feb 23, 2023
Working on `dev` promoting to `prod` See: - ipni/indexstar#87
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Feb 23, 2023
Working on `dev` promoting to `prod` See: - ipni/indexstar#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor backend instantiation such that circuit breaker backends are individually configurable. Reflect changes across the repo.
Add the ability to check if a backend matches a request before attempting to call it. This avoids response slow-down caused by slow backends early in the chain
Introduce a separate configuration to mark cascade lookup backends with explicit matcher in order to avoid routing all requests to them.
Relates to: