Skip to content

Commit

Permalink
Increase max generations for FDB in prod during upgrade
Browse files Browse the repository at this point in the history
Increase max gen during FDB upgrade so that it can proceed.

Investigate manager  role binding issue in prod by elevating role
bindings to cluster level.
  • Loading branch information
masih committed Jul 13, 2023
1 parent fd41e99 commit 1239ba4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
17 changes: 13 additions & 4 deletions deploy/manifests/base/foundationdb/namespaced-manager/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: fdb-kubernetes-operator-controller-manager
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
kind: ClusterRole
metadata:
name: fdb-kubernetes-operator-manager-role
rules:
Expand All @@ -25,6 +25,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- watch
- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -111,13 +119,14 @@ rules:
- watch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
kind: ClusterRoleBinding
metadata:
name: fdb-kubernetes-operator-manager-rolebinding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
kind: ClusterRole
name: fdb-kubernetes-operator-manager-role
subjects:
- kind: ServiceAccount
name: fdb-kubernetes-operator-controller-manager
name: fdb-kubernetes-operator-controller-manager
namespace: storetheindex
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- knob_target_bytes_per_storage_server=2000e6
# Defaults to 750e6
- knob_target_bytes_per_storage_server_batch=1500e6
- knob-max-generations-override=200
- knob-max-generations-override=400
podTemplate:
spec:
topologySpreadConstraints:
Expand Down Expand Up @@ -100,7 +100,7 @@ spec:
- knob_rocksdb_background_parallelism=8
- knob_rocksdb_read_parallelism=16
- knob_rocksdb_checkpoint_reader_parallelism=16
- knob-max-generations-override=200
- knob-max-generations-override=400
podTemplate:
spec:
topologySpreadConstraints:
Expand Down

0 comments on commit 1239ba4

Please sign in to comment.