Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent options implementation #1137

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Consistent options implementation #1137

merged 1 commit into from
Jan 12, 2023

Conversation

gammazero
Copy link
Collaborator

Use consistent options implementation through out this project.

This is a code style change, not a functional change.

Use a consistent options implementation through out this project.
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 56.25% // Head: 56.25% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a05552b) compared to base (ff61987).
Patch coverage: 55.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   56.25%   56.25%   -0.01%     
==========================================
  Files         143      143              
  Lines       14213    14199      -14     
==========================================
- Hits         7996     7987       -9     
+ Misses       5350     5347       -3     
+ Partials      867      865       -2     
Impacted Files Coverage Δ
command/daemon.go 0.00% <0.00%> (ø)
server/admin/http/options.go 33.33% <42.85%> (-1.67%) ⬇️
server/finder/http/options.go 39.47% <44.00%> (+2.88%) ⬆️
dagsync/dtsync/publisher.go 49.49% <50.00%> (-0.01%) ⬇️
server/ingest/http/options.go 33.33% <50.00%> (-1.67%) ⬇️
api/v0/httpclient/options.go 57.89% <55.55%> (+1.89%) ⬆️
api/v0/httpclient/client.go 63.63% <57.14%> (ø)
dagsync/dtsync/option.go 87.50% <60.00%> (+0.54%) ⬆️
internal/registry/option.go 70.00% <60.00%> (+1.57%) ⬆️
server/admin/http/server.go 91.42% <80.00%> (-0.24%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 8c4f8b1 into main Jan 12, 2023
@gammazero gammazero deleted the consistent-options branch January 12, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants