Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to store advertisements and entries in a separate datastore #1149

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

gammazero
Copy link
Collaborator

Separate datastore for ads and entries is optional and only done if the configuration Datastore.DirAdvertisements is set.

Added option, Ingest.KeepAdvertisements, to prevent advertisements and entries from being removed after ingestion.

Separate datastore for ads and entries is optional, and only done if the configuration Datastore.DirAdvertisements is set.

Added option, Ingest.KeepAdvertisements, to prevent advertisements and entries from being removed after ingestion.
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 54.21% // Head: 54.12% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (fd255c3) compared to base (77fb07b).
Patch coverage: 30.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   54.21%   54.12%   -0.09%     
==========================================
  Files         148      149       +1     
  Lines       14757    14811      +54     
==========================================
+ Hits         8000     8016      +16     
- Misses       5884     5920      +36     
- Partials      873      875       +2     
Impacted Files Coverage Δ
command/daemon.go 0.00% <0.00%> (ø)
config/datastore.go 57.14% <ø> (ø)
config/ingest.go 36.53% <ø> (ø)
internal/ingest/option.go 52.94% <52.94%> (ø)
internal/ingest/ingest.go 68.60% <63.15%> (+0.01%) ⬆️
internal/ingest/linksystem.go 72.02% <100.00%> (ø)
server/ingest/test/test.go 55.02% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 42f249c into main Jan 18, 2023
@gammazero gammazero deleted the separate-ad-datastore branch January 18, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants