Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put fixed multiaddr into peerstore #1168

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Put fixed multiaddr into peerstore #1168

merged 1 commit into from
Jan 19, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Jan 19, 2023

Need to store the fixed multiaddr, with the p2p peer ID removed, in the peerstore. This is a follow-up to #1160

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 54.25% // Head: 54.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fc84d05) compared to base (95e814e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   54.25%   54.25%           
=======================================
  Files         149      149           
  Lines       14810    14811    +1     
=======================================
+ Hits         8035     8036    +1     
  Misses       5900     5900           
  Partials      875      875           
Impacted Files Coverage Δ
dagsync/subscriber.go 85.32% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit a7c26bc into main Jan 19, 2023
@gammazero gammazero deleted the fixed-addr-in-peerstore branch January 19, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants