Remove optional metadata query parameter

[ischasny]

Remove metadata query parameter that changed behaviour of whether metadata has been included into extended provider results. Including metadata is required so that the client can correctly assemble extended provider results.

[codecov-commenter]

Codecov Report

Base: 54.16% // Head: 54.08% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (c8d796a) compared to base (53c3bbb).
Patch coverage: 89.47% of modified lines in pull request are covered.

❗ Current head c8d796a differs from pull request most recent head f774da4. Consider uploading reports for the commit f774da4 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   54.16%   54.08%   -0.09%     
==========================================
  Files         149      148       -1     
  Lines       14838    14799      -39     
==========================================
- Hits         8037     8004      -33     
+ Misses       5926     5921       -5     
+ Partials      875      874       -1     

Impacted Files	Coverage Δ
command/providers.go	0.00% <0.00%> (ø)
internal/registry/registry.go	63.92% <50.00%> (ø)
api/v0/finder/client/http/client.go	53.96% <100.00%> (-1.76%)	⬇️
api/v0/finder/client/libp2p/client.go	67.03% <100.00%> (+6.03%)	⬆️
internal/registry/apiconv.go	87.40% <100.00%> (-0.30%)	⬇️
server/finder/handler/finder_handler.go	87.33% <100.00%> (ø)
server/finder/http/handler.go	53.98% <100.00%> (+0.59%)	⬆️
server/finder/libp2p/handler.go	67.01% <100.00%> (+4.39%)	⬆️
server/finder/test/test.go	63.63% <100.00%> (+0.19%)	⬆️
dagsync/p2p/protocol/head/head.go	72.41% <0.00%> (-5.75%)	⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gammazero]

Also need to remove parameter from clients:

• https://github.com/ipni/storetheindex/blob/main/api/v0/finder/client/http/client.go#L74
• https://github.com/ipni/storetheindex/blob/main/api/v0/finder/client/libp2p/client.go#L98-L107
• https://github.com/ipni/storetheindex/blob/main/api/v0/finder/client/interface.go#L23
• https://github.com/ipni/storetheindex/blob/main/command/providers.go#L62

[ischasny]

@gammazero good catch, thanks. Removed - please re-review.

[gammazero]

One suggestion.