Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dhstore into e2e test #1248

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

ischasny
Copy link
Collaborator

@ischasny ischasny commented Feb 7, 2023

  • fix a bug in the double hashed client that caused an invalid memory access if extended providers are nil;
  • add a new flag to storetheindex to specify dhstore url on initialisation;
  • include dhstore and double hashed client into e2e test;
  • allow specifying different urls for dhstore and storetheindex in the double hashed client so that the client can work without indexstar running in front.

Fixes #1214

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 54.00% // Head: 54.56% // Increases project coverage by +0.56% 🎉

Coverage data is based on head (f60eadb) compared to base (0b84c6f).
Patch coverage: 59.09% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
+ Coverage   54.00%   54.56%   +0.56%     
==========================================
  Files         150      150              
  Lines       14958    14969      +11     
==========================================
+ Hits         8078     8168      +90     
+ Misses       5999     5899     -100     
- Partials      881      902      +21     
Impacted Files Coverage Δ
command/flags.go 0.00% <ø> (ø)
command/init.go 48.51% <16.66%> (-2.02%) ⬇️
api/v0/finder/client/http/dhash_client.go 44.86% <75.00%> (+44.86%) ⬆️
dagsync/test/util.go 82.93% <0.00%> (+0.47%) ⬆️
dagsync/p2p/protocol/head/head.go 78.16% <0.00%> (+5.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ischasny ischasny merged commit 400099a into main Feb 7, 2023
@ischasny ischasny deleted the ivan/include-dhstore-to-e2e-test branch February 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E test for double hashed path
3 participants