Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: lower 404 ttl to decrease end user failures" #1365

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Revert "fix: lower 404 ttl to decrease end user failures" #1365

merged 1 commit into from
Mar 7, 2023

Conversation

masih
Copy link
Member

@masih masih commented Mar 7, 2023

Reverts #1344

Experimented with for ~20 minutes at prod, observed the following:

  • Resulted it significant increase in find latency at p75th and above

image

  • Did not increase 200s returned by cid.contat. just 404s shooting up

image

  • High client latency observed by hydras

image

  • No change in Caboose 404 fetch errors

image

Cc @lidel @willscott

@masih masih merged commit de6045d into main Mar 7, 2023
@masih masih deleted the revert-1344-patch-1 branch March 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masih @willscott