Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent use of test library #1392

Merged
merged 2 commits into from
Mar 13, 2023
Merged

More consistent use of test library #1392

merged 2 commits into from
Mar 13, 2023

Conversation

gammazero
Copy link
Collaborator

Use the require consistently in test code. In some test code it is used in some places and not others.
Use the require test utility library in more test code in general to reduce code and have more consistent error messages.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

Patch coverage: 80.76% and project coverage change: +1.13 🎉

Comparison is base (58cc78b) 54.18% compared to head (9687408) 55.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
+ Coverage   54.18%   55.31%   +1.13%     
==========================================
  Files         150      150              
  Lines       15345    15239     -106     
==========================================
+ Hits         8314     8430     +116     
+ Misses       6114     5954     -160     
+ Partials      917      855      -62     
Impacted Files Coverage Δ
server/ingest/test/test.go 45.86% <42.30%> (+19.67%) ⬆️
dagsync/test/util.go 96.96% <100.00%> (+16.87%) ⬆️
server/finder/test/test.go 95.87% <100.00%> (+32.33%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 9a50bf7 into main Mar 13, 2023
@gammazero gammazero deleted the use-test-lib branch March 13, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants