Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up dhstore to indexstar in prod #1412

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

ischasny
Copy link
Collaborator

No description provided.

@ischasny ischasny requested a review from masih March 16, 2023 14:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@80944f6). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage        ?   54.85%           
=======================================
  Files           ?      150           
  Lines           ?    15324           
  Branches        ?        0           
=======================================
  Hits            ?     8406           
  Misses          ?     6060           
  Partials        ?      858           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ischasny ischasny requested a review from willscott March 16, 2023 15:18
@masih
Copy link
Member

masih commented Mar 16, 2023

Let's hold off on this until the latency in prod is figured out

@ischasny
Copy link
Collaborator Author

Let's hold off on this until the latency in prod is figured out

Seems that it has calmed down since yesterday. @masih wdyt?

@ischasny
Copy link
Collaborator Author

FYI I'll also add dhstore to it too

@ischasny ischasny merged commit 47c97f1 into main Mar 17, 2023
@ischasny ischasny deleted the ivan/hook-up-dhstore-to-indexstar branch March 17, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants