Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report pebble metrics #1431

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Report pebble metrics #1431

merged 1 commit into from
Mar 20, 2023

Conversation

ischasny
Copy link
Collaborator

  • Update to the latest version of go-indexer-core that supports metrics reporting
  • Will switch to the release version before merging this PR

@ischasny ischasny requested a review from masih March 20, 2023 17:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (10c2059) 54.89% compared to head (e28dc4c) 54.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
+ Coverage   54.89%   54.97%   +0.07%     
==========================================
  Files         150      150              
  Lines       15324    15324              
==========================================
+ Hits         8412     8424      +12     
+ Misses       6054     6044      -10     
+ Partials      858      856       -2     
Impacted Files Coverage Δ
server/admin/http/server.go 91.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Report pebble metrics alongside indexer metrics from the datastore
@ischasny ischasny force-pushed the ivan/expose-pebble-metrics branch from e28dc4c to 74b0421 Compare March 20, 2023 17:43
@ischasny ischasny merged commit caaad51 into main Mar 20, 2023
@ischasny ischasny deleted the ivan/expose-pebble-metrics branch March 20, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants