Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigner service announce endpoint #1754

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

Need assigner to use newer /announce HTTP endpoint to be compatible with go-libipni HTTP sender.

Fixes ipni/go-libipni#36

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25 🎉

Comparison is base (d08c11f) 51.24% compared to head (838d113) 51.49%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
+ Coverage   51.24%   51.49%   +0.25%     
==========================================
  Files         101      101              
  Lines       11250    11253       +3     
==========================================
+ Hits         5765     5795      +30     
+ Misses       4901     4872      -29     
- Partials      584      586       +2     
Impacted Files Coverage Δ
assigner/server/server.go 41.58% <100.00%> (+1.78%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 2ea1218 into main May 18, 2023
@gammazero gammazero deleted the fix-assigner-announce-ep branch May 18, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using cid.contact as HTTP announce sender URL results in 404
3 participants