Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose port 3003 on assigner pod #1892

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Expose port 3003 on assigner pod #1892

merged 3 commits into from
Jun 6, 2023

Conversation

gammazero
Copy link
Collaborator

No description provided.

@@ -64,6 +64,8 @@ EXPOSE 3002
EXPOSE 3000
# Ingest interface
EXPOSE 3001
# P2P interface
EXPOSE 3003
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small footnote: The exposure of ports here are redundant for the purposes of K8S, but thank you for documenting them in dockerfile.

deploy/manifests/base/assigner/deployment.yaml Outdated Show resolved Hide resolved
Co-authored-by: Masih H. Derkani <m@derkani.org>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (73f2f62) 47.56% compared to head (d6c666e) 47.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   47.56%   47.69%   +0.12%     
==========================================
  Files          95       95              
  Lines       10304    10304              
==========================================
+ Hits         4901     4914      +13     
+ Misses       4823     4812      -11     
+ Partials      580      578       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit f85f21e into main Jun 6, 2023
@gammazero gammazero deleted the assigner-pod-expose-p2p branch June 6, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants