Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New indexers for indexing with FDB #1906

Merged
merged 3 commits into from
Jun 8, 2023
Merged

New indexers for indexing with FDB #1906

merged 3 commits into from
Jun 8, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Jun 7, 2023

Create new indexers for FDB indexing.

  • arya: us-east-2a
  • bala: us-east-2b
  • cera: us-east-2c

These each use a r6a.2xlarge instance with

  • cpu: "7"
  • memory: 60Gi

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (02a179d) 47.76% compared to head (9cae90f) 47.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
+ Coverage   47.76%   47.88%   +0.11%     
==========================================
  Files          95       95              
  Lines       10250    10250              
==========================================
+ Hits         4896     4908      +12     
+ Misses       4788     4771      -17     
- Partials      566      571       +5     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good thanks @gammazero

The only issue is that we need to define node workgroups for r6a.2xlarge since they do not currently exist in K8S Cluster.

I'll get that sorted and Cc you for visibility. After that we can get the shiny new indexers up 🚀

masih added a commit that referenced this pull request Jun 8, 2023
These are the instance types that will be used by the new indexers
pointed to FDB backed dhstores.

Relates to:
 - #1906
masih added a commit that referenced this pull request Jun 8, 2023
These are the instance types that will be used by the new indexers
pointed to FDB backed dhstores.

Relates to:
 - #1906
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New work groups are up. We are good to go

This would leave 1 CPU for daemon sets that would be scheduled on the
machine to collect logs etc, since the instance type offers only 8 CPUs.
@gammazero gammazero merged commit a9b3463 into main Jun 8, 2023
@gammazero gammazero deleted the new-indexers branch June 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants