-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New indexers for indexing with FDB #1906
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
+ Coverage 47.76% 47.88% +0.11%
==========================================
Files 95 95
Lines 10250 10250
==========================================
+ Hits 4896 4908 +12
+ Misses 4788 4771 -17
- Partials 566 571 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good thanks @gammazero
The only issue is that we need to define node workgroups for r6a.2xlarge
since they do not currently exist in K8S Cluster.
I'll get that sorted and Cc you for visibility. After that we can get the shiny new indexers up 🚀
These are the instance types that will be used by the new indexers pointed to FDB backed dhstores. Relates to: - #1906
These are the instance types that will be used by the new indexers pointed to FDB backed dhstores. Relates to: - #1906
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New work groups are up. We are good to go
This would leave 1 CPU for daemon sets that would be scheduled on the machine to collect logs etc, since the instance type offers only 8 CPUs.
Create new indexers for FDB indexing.
These each use a
r6a.2xlarge
instance with