Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy caching in cassette #1963

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Deploy caching in cassette #1963

merged 1 commit into from
Jun 13, 2023

Conversation

masih
Copy link
Member

@masih masih commented Jun 13, 2023

Set cache expiry to 24 hours with cache size of 1M. The caching memory footprint is unclear just now. Further experimentation is needed to right-size the instance relative to cache size.

Use a reduced cache expiry and size for dev environment.

See:

Set cache expiry to 24 hours with cache size of 1M. The caching memory
footprint is unclear just now. Further experimentation is needed to
right-size the instance relative to cache size.

Use a reduced cache expiry and size for `dev` environment.

See:
 - ipni/cassette#38
@masih masih requested a review from willscott June 13, 2023 14:06
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (91eca3d) 47.63% compared to head (b6ee783) 47.60%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
- Coverage   47.63%   47.60%   -0.03%     
==========================================
  Files          95       95              
  Lines       10250    10250              
==========================================
- Hits         4883     4880       -3     
- Misses       4799     4803       +4     
+ Partials      568      567       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masih masih merged commit d8cfd5e into main Jun 13, 2023
@masih masih deleted the masih/cassette_cache branch June 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants