Make rewriting the mirror when resyncing configurable #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
approved these changes
Jun 27, 2023
| @@ -55,6 +55,8 @@ type Ingest struct { | |||
| // MinimumKeyLengt causes any multihash, that has a digest length less than | |||
| // this, to be ignored. | |||
| MinimumKeyLength int | |||
| // OverwriteMirrorOnResync overwrites the advertisement when resyncing. | |||
| OverwriteMirrorOnResync bool | |||
There was a problem hiding this comment.
At some point we probably this configurable per admin sync --resync command as well?
There was a problem hiding this comment.
Agree, but that will slightly more complicated because of how the resync flag is passed through. I can do that in a separate PR. #2031
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2030 +/- ##
==========================================
+ Coverage 47.75% 47.94% +0.19%
==========================================
Files 94 94
Lines 10286 10286
==========================================
+ Hits 4912 4932 +20
+ Misses 4806 4782 -24
- Partials 568 572 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resyncing, sometimes we want to rewrite the mirror, usually we do not.
We may want to rewrite the mirror to get rid of the deleted multihash data that is not needed or to re-encode or compress differently. Usually, we will only want to read existing CAR files from the mirror when resyncing.