Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dhfind with new dhstore #2084

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Replace dhfind with new dhstore #2084

merged 2 commits into from
Jul 5, 2023

Conversation

gammazero
Copy link
Collaborator

  • Set dhfind replica count to 0
  • Replace dhfind with dhstore in indexstar config

To be deployed after #2083

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (336eb83) 47.95% compared to head (141ef4c) 47.98%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
+ Coverage   47.95%   47.98%   +0.02%     
==========================================
  Files          94       94              
  Lines       10306    10306              
==========================================
+ Hits         4942     4945       +3     
+ Misses       4790     4788       -2     
+ Partials      574      573       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge after #2083 deployment is all good 👍

- Set dhfind replica count to 0
- Replace dhfind with dhstore in indexstar config

To be deployed after #2083
@gammazero gammazero force-pushed the prod-remove-dhfind branch from 141ef4c to a909d38 Compare July 5, 2023 15:22
@gammazero gammazero merged commit cfbb224 into main Jul 5, 2023
@gammazero gammazero deleted the prod-remove-dhfind branch July 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants