Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FDB 7.2 and 7.3 binaries to controller in prep for upgrade #2122

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

masih
Copy link
Member

@masih masih commented Jul 13, 2023

In preparation for upgrading foundation db, add the binaries for two higher versions with the latest patch.

In preparation for upgrading foundation db, add the binaries for two
higher versions with the latest patch.
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.98 🎉

Comparison is base (c9a0a61) 48.07% compared to head (148ed4c) 50.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
+ Coverage   48.07%   50.06%   +1.98%     
==========================================
  Files          94       94              
  Lines       10306    10802     +496     
==========================================
+ Hits         4955     5408     +453     
- Misses       4779     4831      +52     
+ Partials      572      563       -9     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masih masih requested a review from gammazero July 13, 2023 20:21
Copy link
Collaborator

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that after upgrade we can get rid of the multiple versions.

@masih
Copy link
Member Author

masih commented Jul 13, 2023

I assume that after upgrade we can get rid of the multiple versions.

Indeed. For now we want to support older versions for server side experimentation, and graceful client side upgrades.

@masih masih merged commit 203f1cd into main Jul 13, 2023
@masih masih deleted the masih/fdb_upgrade_binaries branch July 13, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants