Fix panic in bootstrap #2155
Merged
Fix panic in bootstrap #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bootstrap config function LoadTempBootstrapPeers is not defined, then bootstrapping panics. This happens here, because a nil function is called: https://github.com/ipfs/kubo/blob/master/core/bootstrap/bootstrap.go#L248
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
- Coverage 47.30% 47.12% -0.18%
==========================================
Files 92 92
Lines 10009 10047 +38
==========================================
Hits 4735 4735
- Misses 4735 4773 +38
Partials 539 539
☔ View full report in Codecov by Sentry. |
|
Force merging, since this fixes a panic in already-merged code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bootstrap config function LoadTempBootstrapPeers is not defined, then bootstrapping panics.
This happens here, because a nil function is called: https://github.com/ipfs/kubo/blob/master/core/bootstrap/bootstrap.go#L248