Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function that signs advertisements #217

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

masih
Copy link
Member

@masih masih commented Feb 14, 2022

Export the function that is used to sign advertisements so that it can
be reused for testing purposes in index-provider.

Note that its counterpart verify function is already exported.

Bump version in preparation for release.

Export the function that is used to sign advertisements so that it can
be reused for testing purposes in `index-provider`.

Note that its counterpart verify function is already exported.

Bump version in preparation for release.
@masih masih requested review from willscott and gammazero February 14, 2022 13:35
@github-actions
Copy link
Contributor

Suggested version: v0.3.2
Comparing to: v0.3.1 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/filecoin-project/storetheindex/api/v0/ingest/schema
## compatible changes
SignAdvertisement: added

# summary
Suggested version: v0.4.0

gocompat says:

(empty)

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #217 (dbc1835) into main (872e864) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   28.90%   28.96%   +0.06%     
==========================================
  Files          84       84              
  Lines       11645    11645              
==========================================
+ Hits         3366     3373       +7     
+ Misses       7770     7765       -5     
+ Partials      509      507       -2     
Impacted Files Coverage Δ
api/v0/ingest/schema/envelope.go 67.27% <100.00%> (ø)
api/v0/ingest/schema/utils.go 65.00% <100.00%> (ø)
internal/ingest/linksystem.go 61.64% <0.00%> (+0.17%) ⬆️
internal/ingest/cidwaiter.go 77.96% <0.00%> (+10.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872e864...dbc1835. Read the comment docs.

@masih
Copy link
Member Author

masih commented Feb 14, 2022

CI test failures seem unrelated and down to intermittently failing tests it seems.
merging.

@masih masih merged commit e384ae9 into main Feb 14, 2022
@masih masih deleted the masih/export-ad-sign branch February 14, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants