Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to remove all temporary data at startup #2395

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

gammazero
Copy link
Collaborator

Context

Temporary data, that has been abandoned, may accumulate over time. It may be desirable to get rid of it between indexer runs.

Proposed Changes

Adds a new config file option to remove temporary data at start time.

Tests

Unit tests to check that feature works correctly

Revert Strategy

Change is safe to revert.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (79199f3) 48.05% compared to head (407ebd5) 48.40%.

Files Patch % Lines
command/datastore.go 21.62% 25 Missing and 4 partials ⚠️
command/daemon.go 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   48.05%   48.40%   +0.34%     
==========================================
  Files          82       82              
  Lines        9788     9792       +4     
==========================================
+ Hits         4704     4740      +36     
+ Misses       4550     4507      -43     
- Partials      534      545      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 5547a84 into main Nov 17, 2023
9 checks passed
@gammazero gammazero deleted the opt-rm-tmp-datastore branch November 17, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants