Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dockerfile for a minimal non-root image #2504

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

masih
Copy link
Member

@masih masih commented Feb 8, 2024

Remove user switch and additional binary installations from Dockerfile for a minimal non-root image that still contains a shell, at entrypoint sh.

Remove user switch and additional binary installations from Dockerfile
for a minimal non-root image that still contains a shell, at entrypoint
`sh`.
@masih masih requested review from gammazero and willscott February 8, 2024 16:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6083519) 45.60% compared to head (fd74773) 45.64%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   45.60%   45.64%   +0.04%     
==========================================
  Files          85       85              
  Lines       10733    10734       +1     
==========================================
+ Hits         4895     4900       +5     
+ Misses       5247     5244       -3     
+ Partials      591      590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

Copy link
Collaborator

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to run the assigner subcommand when running this as an assigner. This means there is some additional change that needs to be made to deployment.

@masih masih merged commit a622ff5 into main Feb 9, 2024
9 of 11 checks passed
@masih masih deleted the masih/simplify-dockerfile branch February 9, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants