Separate read and write storage backend for mirror #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
- Coverage 45.71% 45.64% -0.08%
==========================================
Files 85 85
Lines 10767 10777 +10
==========================================
- Hits 4922 4919 -3
- Misses 5251 5267 +16
+ Partials 594 591 -3 ☔ View full report in Codecov by Sentry. |
masih
force-pushed
the
masih/mirror-read-write-separate
branch
2 times, most recently
from
c7afafd to
86e78c4
Compare
gammazero
approved these changes
Feb 15, 2024
masih
force-pushed
the
masih/mirror-read-write-separate
branch
from
800d017 to
9161736
Compare
gammazero
approved these changes
Feb 15, 2024
masih
force-pushed
the
masih/mirror-read-write-separate
branch
from
153b575 to
a14eed0
Compare
Allow district read side and write side configuration for ad mirror. This enables a storage backend to be passively populated from a retrieval backend since ingest will attempt to store all processed ads regardless of their retrieval origin.
masih
force-pushed
the
masih/mirror-read-write-separate
branch
from
a14eed0 to
0a64140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow district read side and write side configuration for ad mirror.
This enables a storage backend to be passively populated from a retrieval backend since ingest will attempt to store all processed ads regardless of their retrieval origin.