Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --days control to npm grab script #2127

Closed
wants to merge 2 commits into from
Closed

Added --days control to npm grab script #2127

wants to merge 2 commits into from

Conversation

HNJAMeindersma
Copy link

Answering half of my own question by adding --days control to the npm grab script that invokes epg-grabber.

Add argument to `grab` script for npm.
Update README.md for --days control
@HNJAMeindersma
Copy link
Author

HNJAMeindersma commented Jul 8, 2023

It does seem to fall back to 1 day when the DAYS= argument isn't passed, ignoring the default --days value in /sites/example.com/example.com.config.js all together. Maybe creating a copy of the grab script inside /package.json would be a better solution for compatibility sake.

"grab":      "cross-var epg-grabber --config=sites/$SITE/$SITE.config.js --channels=sites/$SITE/$SITE.channels.xml --output=guides/{lang}/{site}.xml",
"grab-days": "cross-var epg-grabber --config=sites/$SITE/$SITE.config.js --channels=sites/$SITE/$SITE.channels.xml --output=guides/{lang}/{site}.xml --days=$DAYS",

What do the maintainers think of this matter?

@freearhey
Copy link
Collaborator

We store all site settings in configs, so there is no need to specify additional arguments. But if you need more fine-tuning you can just use epg-grabber directly, like so:

npx epg-grabber --config=sites/example.com/example.com.config.js --channels=sites/example.com/example.com.channels.xml --output=guides/{lang}/{site}.xml

The same goes for the channel list, you can simply create a file with only the channels you want and specify the path to it.

@freearhey freearhey closed this Jul 9, 2023
@HNJAMeindersma
Copy link
Author

We store all site settings in configs, so there is no need to specify additional arguments. But if you need more fine-tuning you can just use epg-grabber directly, like so:

npx epg-grabber --config=sites/example.com/example.com.config.js --channels=sites/example.com/example.com.channels.xml --output=guides/{lang}/{site}.xml

The same goes for the channel list, you can simply create a file with only the channels you want and specify the path to it.

@freearhey
In my opinion that defeats the purpose of this repository: a central actively maintained source of active and working grabbers with their config. From my point of view there is no need to set a "fixed" number of days per grabber site, unless the source starts putting out wild errors when you ask for to many days.

Same goes for white-/blacklisting channels. Building my own channels.xml defeats the purpose of this repository. Since it seems much less work to use the channels.xml from iptv-org as a base and then making some smaller adjustments of the scope by white-/blacklisting a small part of a premade channels.xml. I'm not looking to remake a custom personal channels.xml every time this repo is updated and a channel is added or removed that lays within my interest of watching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants