Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbviewer_theme: SyntaxError: Unexpected identifier #673

Closed
hainm opened this issue Jul 21, 2016 · 2 comments
Closed

nbviewer_theme: SyntaxError: Unexpected identifier #673

hainm opened this issue Jul 21, 2016 · 2 comments

Comments

@hainm
Copy link

hainm commented Jul 21, 2016

FYI: https://github.com/ipython-contrib/IPython-notebook-extensions/blob/master/nbextensions/publishing/nbviewer_theme/main.js#L9-L10

below code does not work in my old Chrome

            var val = $(this).val()
            if val == 'default'
@juhasch
Copy link
Member

juhasch commented Jul 22, 2016

I don't know what this extension is supposed to do, actually. I guess it should be removed.
Feel free to submit a PR to fix and document it, if it is of any use to you.

@jcb91
Copy link
Member

jcb91 commented Mar 29, 2017

closing, as nbviewer_theme was removed in #906

@jcb91 jcb91 closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants